Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong product icon size in DAboutDialog #580

Merged
merged 1 commit into from
Jul 1, 2024
Merged

fix: wrong product icon size in DAboutDialog #580

merged 1 commit into from
Jul 1, 2024

Conversation

zty199
Copy link
Contributor

@zty199 zty199 commented Jun 12, 2024

when compiled with Qt6, product icon size is set to windowHandle().baseSize()
which is not the same as compiled with Qt5 (fixed size 128x128)

Log: use 128x128 pixmap in DAboutDialog::setProductIcon

@deepin-ci-robot
Copy link
Contributor

Hi @zty199. Thanks for your PR. 😃

@deepin-ci-robot
Copy link
Contributor

Hi @zty199. Thanks for your PR.

I'm waiting for a linuxdeepin member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Jun 12, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#580
kegechen
kegechen previously approved these changes Jun 12, 2024
@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jun 12, 2024

Doc Check bot
🟢 Document Coverage Check Passed!

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jun 27, 2024

TAG Bot

New tag: 5.6.31
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #583

@zty199 zty199 closed this Jul 1, 2024
@zty199 zty199 reopened this Jul 1, 2024
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Jul 1, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#580
deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Jul 1, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#580
when compiled with Qt6, product icon size is set to windowHandle().baseSize()
which is not the same as compiled with Qt5 (fixed size 128x128)

Log: use 128x128 pixmap in DAboutDialog::setProductIcon
@deepin-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kegechen, zty199

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deepin-ci-robot
Copy link
Contributor

deepin pr auto review

关键摘要:

  • 在代码更改中,将窗口大小从baseSize()更改为QSize(128, 128)可能会导致图标显示不正确,因为原始大小可能与baseSize()不同。需要确认图标是否确实需要调整为128x128像素。
  • 注释// TODO: wait for checking表明可能存在未完成的工作,应该确认是否已经完成了所有必要的检查。
  • 代码中使用了windowHandle(),但没有检查windowHandle()是否返回了一个有效的窗口句柄。应该添加对windowHandle()返回值的检查,以确保窗口存在且可以访问。

是否建议立即修改:

  • 是,需要确保图标大小更改是必要的,并且不会导致图标显示不正确。
  • 是,应该立即检查windowHandle()的返回值,以确保窗口可以被正确处理。

deepin-ci-robot added a commit to linuxdeepin/dtk6widget that referenced this pull request Jul 1, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#580
@kegechen
Copy link
Contributor

kegechen commented Jul 1, 2024

/merge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jul 1, 2024

This pr cannot be merged! (status: blocked)

@kegechen
Copy link
Contributor

kegechen commented Jul 1, 2024

/forcemerge

@deepin-bot
Copy link
Contributor

deepin-bot bot commented Jul 1, 2024

This pr force merged! (status: blocked)

@deepin-bot deepin-bot bot merged commit 8df23f4 into linuxdeepin:master Jul 1, 2024
18 of 21 checks passed
mhduiy pushed a commit to linuxdeepin/dtk6widget that referenced this pull request Jul 3, 2024
Synchronize source files from linuxdeepin/dtkwidget.

Source-pull-request: linuxdeepin/dtkwidget#580
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants