Implement persistent keys #2252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hreinecke
force-pushed
the
persistent-keys
branch
from
4caa6bd to
893f1c4
Compare
igaw
reviewed
Mar 19, 2024
| return err; | ||
|
|
||
| if (cfg.keyfile) { | ||
| fd = fopen(cfg.keyfile, "r"); |
There was a problem hiding this comment.
For export, shouldn't this file be opened with in write mode?
|
Looks good to me. Let's wait a bit and see if there are some more comments coming in. |
As we now have library functions for importing and exporting TLS keys we should be using them. Signed-off-by: Hannes Reinecke <[email protected]>
To include missing symbol nvme_scan_tls_keys. Signed-off-by: Hannes Reinecke <[email protected]>
Add a new function 'tls_key' to import and export keys from the keyring. Signed-off-by: Hannes Reinecke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new utility 'tls-key' to import or export keys to or from the kernel keystore.