wdc: Fix timestamp displayed by vs-firmware-activate-history command #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-lien-sndk
force-pushed
the
wdc-timestamp-fix
branch
3 times, most recently
from
804c65a to
ab7f3ae
Compare
The actual timestamp value is in bytes 0:5 of the 8 byte field. The code was using all 8 bytes so a change was made to mask off the top 2 bytes. The timestamp calculations were also simplified to be more maintainable. Signed-off-by: jeff-lien-wdc <[email protected]>
Changes based on review comments. Fixed build errors building timestamp string. Fixed lines over the 100 char limit. Signed-off-by: jeff-lien-wdc <[email protected]>
jeff-lien-sndk
force-pushed
the
wdc-timestamp-fix
branch
from
ab7f3ae to
e287f25
Compare
|
@martin-belanger @igaw Fixed build and checkpatch issues with the latest commits. Also addressed review comments from Martin. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual timestamp value is in bytes 0:5 of the 8 byte field. The code was using all 8 bytes so a change was made to mask off the top 2 bytes. The timestamp calculations were also simplified to be more maintainable.