Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvme-print-stdout: Add hexadecimal value 0x prefix #2238

Merged
merged 3 commits into from
Mar 18, 2024

Conversation

ikegami-t
Copy link
Contributor

Also unify to use %#x or %#"PRIx64" instead of 0x%x and 0x%"PRIx64".

@ikegami-t ikegami-t force-pushed the prefix-0x branch 3 times, most recently from c2f7784 to 26073f8 Compare March 12, 2024 16:31
@igaw
Copy link
Collaborator

igaw commented Mar 13, 2024

I'm a bit worried about the changing the format from %x to %#x, because it changes the output format slightly. It might break users. Not sure if it's worth the trouble. I am fine with changing 0x%x to %#x to make these parts consistent.

This resolves checkpatch line length exceeding warning.

Signed-off-by: Tokunori Ikegami <[email protected]>
The output printed with the 0x prefix but as not hexadecimal.

Signed-off-by: Tokunori Ikegami <[email protected]>
Also channge 64bit value to use  %#"PRIx64" instead of 0x%"PRIx64".

Signed-off-by: Tokunori Ikegami <[email protected]>
@ikegami-t
Copy link
Contributor Author

Just reverted to %x from %#x and only change 0x%x to %#x. Thank you.

@igaw igaw merged commit df11a0e into linux-nvme:master Mar 18, 2024
16 checks passed
@igaw
Copy link
Collaborator

igaw commented Mar 18, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants