nvme: Add support for dsm command latency option #2237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikegami-t
force-pushed
the
nvme-dsm-latency-2
branch
from
8803b79 to
0822641
Compare
| err = nvme_dsm(&args); | ||
| gettimeofday(&end_time, NULL); | ||
| if (cfg.latency) | ||
| printf(" latency: %s: %llu us\n", __func__, elapsed_utime(start_time, end_time)); |
There was a problem hiding this comment.
It may be more desirable to call gettimeofday() only when it's needed.
if (cfg.latency)
gettimeofday(&start_time, NULL);
err = nvme_dsm(&args);
if (cfg.latency) {
gettimeofday(&end_time, NULL);
printf(" latency: %s: %llu us\n", __func__, elapsed_utime(start_time, end_time));
}
There was a problem hiding this comment.
Thanks for your comment. Just fixed as mentioned. By the way both submit_io() and passthru() also may be needed to fix as same.
The purpose to add is for adding performance statistics. Currently the latency option is only added for passthru() and submit_io(). The verbose option also outputs the latency but other debuging info. So add for the dsm command also to output only the latency info. Signed-off-by: Tokunori Ikegami <[email protected]>
ikegami-t
force-pushed
the
nvme-dsm-latency-2
branch
from
0822641 to
fb786a2
Compare
|
This is already available via increasing the verbosity level to debug. All |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose to add is for adding performance statistics. Currently the latency option is only added for passthru() and submit_io(). The verbose option also outputs the latency but other debuging info. So add for the dsm command also to output only the latency info.