Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not print error message if ACPI tables are no present #2202

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

igaw
Copy link
Collaborator

@igaw igaw commented Feb 2, 2024

Fixes: #2198

igaw added 2 commits February 2, 2024 08:47
libnvme.h is from an external source, so use the correct include
grammar.

Signed-off-by: Daniel Wagner <[email protected]>
Not all architectures have ACPI tables, e.g. riscv64. Thus the nbft code
should fail gracefully if it's not present.

Signed-off-by: Daniel Wagner <[email protected]>
@igaw
Copy link
Collaborator Author

igaw commented Feb 2, 2024

@mwilck @tbzatek are you okay with this change?

Copy link
Contributor

@mwilck mwilck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me.

@igaw igaw merged commit 3196089 into linux-nvme:master Feb 2, 2024
16 checks passed
@igaw
Copy link
Collaborator Author

igaw commented Feb 2, 2024

Thanks!

@igaw igaw deleted the fix-nbft branch February 2, 2024 10:09
Copy link
Contributor

@tbzatek tbzatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider disable NBFT when ACPI is not present
3 participants