Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mi: set correct rc and errno when crc mismatch #773

Merged
merged 1 commit into from
Jan 22, 2024
Merged

mi: set correct rc and errno when crc mismatch #773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/nvme/mi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,8 @@ int nvme_mi_submit(nvme_mi_ep_t ep, struct nvme_mi_req *req,
rc = nvme_mi_verify_resp_mic(resp);
if (rc) {
nvme_msg(ep->root, LOG_WARNING, "crc mismatch\n");
return rc;
errno = EBADMSG;
return -1;
}
}

Expand Down
2 changes: 1 addition & 1 deletion test/mi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ static void test_invalid_crc(nvme_mi_ep_t ep)

test_set_transport_callback(ep, test_invalid_crc_cb, NULL);
rc = nvme_mi_mi_read_mi_data_subsys(ep, &ss_info);
assert(rc != 0);
assert(rc < 0);
}

/* test: test that the controller list populates the endpoint's list of
Expand Down