Fix optional shellcheck warnings for hook.sh #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an optional shellcheck warning to use double square brackets for bash
scripts:
In meta-lxatac-software/recipes-core/bundles/files/hook.sh line 26:
if [ "${bundle_hash}" == "${cert_hash}" ]; then
^-- SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
In meta-lxatac-software/recipes-core/bundles/files/hook.sh line 39:
if [ ! -f "$1" ]; then
^-----------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in Bash/Ksh.
Signed-off-by: Rouven Czerwinski <[email protected]>
Fix an optional shellcheck warning:
In meta-lxatac-software/recipes-core/bundles/files/hook.sh line 60:
migrate "$x"
^-- SC2250 (style): Prefer putting braces around variable references even when not strictly required.
Signed-off-by: Rouven Czerwinski <[email protected]>
1 task
hnez
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Very nice!
This PR inspired me to add a CI job for shellcheck to meta-lxatac. See #86 for that.
We have to figure out why it does not run though, but I can already tell that there is a lot more potential for improvement.
But as an incremental improvement this is already great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some minor optional shellcheck warnings within hook.sh.