meta-lxatac-bsp: emmc-image: specify image for state/env even with fill: #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes failing builds caused by commit daccfdd ("meta-ptx: update to current master with genimage v17"), which removed the image parameter for the barebox state and environment partition in the assumption that specifying the fill parameter instead would result in the partition being zeroed out. This is not correct. genimage still needs an image name for the partition, but now it may have a length of zero because the rest of the partition (e.g. everything) will be filled with zeros. This fixes these genimage build errors: | INFO: cmd: "rm -rf "…/build/tmp/work/lxatac-oe-linux-gnueabi/emmc-image/1.0/genimage-tmp"/*" (stderr): | INFO: android-sparse(emmc-image-lxatac-2024…15.simg): input image: emmc-image-lxatac-2024…15.img | ERROR: hdimage(emmc-image-lxatac-2024…15.img): no input file given | INFO: cmd: "rm -rf "…/build/tmp/work/lxatac-oe-linux-gnueabi/emmc-image/1.0/genimage-tmp"/*" (stderr): | WARNING: exit code 1 from a shell command. Fixes: daccfdd ("meta-ptx: update to current master with genimage v17") Signed-off-by: Leonard Göhrs <[email protected]>
jluebbe
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes failing builds caused by commit daccfdd ("meta-ptx: update to current master with genimage v17") in PR #117, which removed the image parameter for the barebox state and environment partition in the assumption that specifying the fill parameter instead would result in the partition being zeroed out.
This is not correct. genimage still needs an image name for the partition, but now it may have a length of zero because the rest of the partition (e.g. everything) will be filled with zeros.
This fixes these genimage build errors: