meta-lxatac-bsp: lxatac-factory-data: order service before udev #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelolbrich
requested changes
Feb 23, 2024
meta-lxatac-bsp/recipes-core/lxatac-factory-data/files/lxatac-factory-data.service
Outdated
Show resolved
Hide resolved
meta-lxatac-bsp/recipes-core/lxatac-factory-data/files/lxatac-factory-data.sh
Show resolved
Hide resolved
meta-lxatac-bsp/recipes-core/lxatac-factory-data/files/lxatac-factory-data.sh
Show resolved
Hide resolved
Signed-off-by: Leonard Göhrs <[email protected]>
We want to pull the exectution of the factory-data script earlier in the boot process, so it runs before udev starts. Relying on a DBus service to get and set the hostname goes against that goal. Just asking the kernel and writing to /etc/hostname is more or less equivalent to what we have done before, so just do that. Signed-off-by: Leonard Göhrs <[email protected]>
This makes sure that our tac-bridge.link file is ready before udev reads it. We have previously run into race conditions where the file was not present at the correct point in time, resulting in the bridge interface coming up with the wrong MAC address. Signed-off-by: Leonard Göhrs <[email protected]>
hnez
force-pushed
the
tac-bridge-link-order
branch
from
246e9a6 to
07a08bd
Compare
michaelolbrich
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an altternative to #107. Since both approaches are valid and have their benefits and drawbacks I made this a competing PR.
Order the factory data collecting service before the udev systemd service to make sure that the
.linkfile it creates exists before udev starts looking for rules.This should fix an issue we have that results in the
tac-bridgeinterface having the wrong MAC address on some boots.In contrast to #107 it does so without triggering udev to reload its rules.