Skip to content

Commit

Permalink
meta-lxatac-bsp: emmc-image: specify image for state/env even with fill:
Browse files Browse the repository at this point in the history
This fixes failing builds caused by commit daccfdd ("meta-ptx: update
to current master with genimage v17"), which removed the image parameter
for the barebox state and environment partition in the assumption that
specifying the fill parameter instead would result in the partition
being zeroed out.

This is not correct. genimage still needs an image name for the partition,
but now it may have a length of zero because the rest of the partition
(e.g. everything) will be filled with zeros.

This fixes these genimage build errors:

  | INFO: cmd: "rm -rf "…/build/tmp/work/lxatac-oe-linux-gnueabi/emmc-image/1.0/genimage-tmp"/*" (stderr):
  | INFO: android-sparse(emmc-image-lxatac-2024…15.simg): input image: emmc-image-lxatac-2024…15.img
  | ERROR: hdimage(emmc-image-lxatac-2024…15.img): no input file given
  | INFO: cmd: "rm -rf "…/build/tmp/work/lxatac-oe-linux-gnueabi/emmc-image/1.0/genimage-tmp"/*" (stderr):
  | WARNING: exit code 1 from a shell command.

Fixes: daccfdd ("meta-ptx: update to current master with genimage v17")
Signed-off-by: Leonard Göhrs <[email protected]>
  • Loading branch information
hnez committed Mar 4, 2024
1 parent eb0691f commit 6062bda
Showing 1 changed file with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,15 @@ image @IMAGE@img {
}

partition barebox-env {
image = "/dev/zero"
fill = true
in-partition-table = false
offset = 512K
size = 256K
}

partition barebox-state {
image = "/dev/zero"
fill = true
# We can not have the barebox partitions in the partition table right
# now because:
Expand Down

0 comments on commit 6062bda

Please sign in to comment.