bug(obj): Fix temporary keys with long bucket names #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When bucket names are >34 characters, the `createTempKeys` function begins to fail, as linode requires that object storage access keys are <= 50 chars. This change truncates bucket names to 34 characters for that label when required. In the future, it may be desirable to reduce the label further and add a suffix that implies a name was truncated, but I haven't found an existing pattern for that in this provider.
endocrimes
requested review from
lgarber-akamai and
yec-akamai
and removed request for
a team
lgarber-akamai
approved these changes
Jan 15, 2025
yec-akamai
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
What does this PR do and why is this change necessary?
When bucket names are >34 characters, the
createTempKeysfunction begins to fail, as linode requires that object storage access keys are <= 50 chars. This change truncates bucket names to 34 characters for that label when required.In the future, it may be desirable to reduce the label further and add a suffix that implies a name was truncated, but I haven't found an existing pattern for that in this provider.
✔️ How to Test
What are the steps to reproduce the issue or verify the changes?
banana-global-loving-skunk-loki-chunks) with Terraform andobj_use_temp_keysset.How do I run the relevant unit/integration tests?
I haven't added a test for this explicitly as the obj
resource_testis mildly tricky to setup for first time use, but if this change is desirable I can add one.