Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: changed logger to consolelog removed processexit #1

Merged
merged 6 commits into from
Jul 15, 2024
Merged

feat: changed logger to consolelog removed processexit #1

merged 6 commits into from
Jul 15, 2024

Conversation

ElderMatt
Copy link
Collaborator

@ElderMatt ElderMatt commented Jul 11, 2024 •
edited
Loading

This PR:

  • removes the process.exit(1) from the watcher function
  • replaces the this.logger with console.log
  • Changes the package information

ferruhcihan
ferruhcihan requested changes Jul 11, 2024
View reviewed changes
Copy link

@ferruhcihan ferruhcihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous package information is still in the README file.

@ElderMatt ElderMatt requested a review from ferruhcihan July 15, 2024 08:10
ferruhcihan
ferruhcihan approved these changes Jul 15, 2024
View reviewed changes
Copy link

@ferruhcihan ferruhcihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@ferruhcihan ferruhcihan merged commit b7aea05 into main Jul 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferruhcihan ferruhcihan ferruhcihan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ElderMatt @ferruhcihan