Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prefixmaps with new bioregistry and go-site metadata #74

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

sierra-moxon
Copy link
Member

@sierra-moxon sierra-moxon commented Jul 18, 2024

update prefixmaps data with changes from both bioregistry and go-site metadata.

in particular, this fixes prefix expansion for NCBITaxon for GO (does not change NCBITaxon for the rest of the maps)

@sierra-moxon
Copy link
Member Author

@amc-corey-cox @kevinschaper - I need to make a prefixmaps update to support GO prefix changes. Do you want to take a look at this PR to see the changes?

Copy link
Contributor

@amc-corey-cox amc-corey-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks low risk to me so I'm just going to approve it. I need to work out a SOP for testing these changes quickly when we update prefixmaps but this doesn't look like we need to worry too much about it.

@sierra-moxon sierra-moxon merged commit c61e812 into main Jul 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants