Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65
A few things going on here:
[tool.poetry.dependencies]
section, with a few specified as part of extras for documentation generation and data refresh. If we weren't using Poetry for development, extras would make sense. But with Poetry, I believe dependency groups are a better alternative here. These are development-only dependencies, so there's no risk of them leaking out to downstream clients. I've reorganized the dependencies into 4 groups: the main one (intool.poetry.dependencies
-- these are the ones required for a 3rd party to install the package), plus test, docs, and refresh (these ones will only be available afterpoetry install
-ing a development environment).sphinx
dependency to">=7.0.0"
. I don't see any obvious reason why that would be a problem, and it allows us to restore Python 3.8 compatibility. I also let thesphinx
plugin dependencies be anything compatible ("*"
).typing-extensions
andpydantic
. These ultimately get brought in nonetheless as transitive dependencies (pydantic
throughcuries
, andtyping-extensions
throughpydantic
). But if we're not using them directly there's no need for use to declare them.matrix
from thelint
job of.github/workflows/main.yaml