fix(permissiblevalue): serialization #346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #346 +/- ##
=======================================
Coverage 63.43% 63.44%
=======================================
Files 63 63
Lines 8982 8984 +2
Branches 2574 2574
=======================================
+ Hits 5698 5700 +2
Misses 2665 2665
Partials 619 619 ☔ View full report in Codecov by Sentry. |
|
It is a bit concerning that this patch is not breaking any tests... So apparently no tests are validating the serialization of |
Serialization of `PermissibleValue(text='value')` should be `'value'`,
instead it is `PermissibleValue({"text": 'value'})`. This patch fixes
it.
Signed-off-by: Silvano Cirujano Cuesta <[email protected]>
Serialization of PermissibleValues was not being tested until now. This commit improves that coverage. Signed-off-by: Silvano Cirujano Cuesta <[email protected]>
|
This code is generated, so merging this does not make any sense. Therefore closing it. The generator will have to be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serialization of
PermissibleValue(text='value')should be'value', instead it isPermissibleValue({"text": 'value'}). This patch fixes it.Fixes linkml/linkml#2382