Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove slot name redundancy in get_slots_by_enum method #294

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

sierra-moxon
Copy link
Member

@sierra-moxon sierra-moxon commented Jan 8, 2024

to avoid doc displays like this:
https://biolink.github.io/biolink-model/ChemicalOrGeneOrGeneProductFormOrVariantEnum/
(Slots section)

While I was in there, I also converted the tests associated with this method to pytest and added the schema as a fixture.

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (a39fd65) 62.12% compared to head (801973d) 61.99%.
Report is 1 commits behind head on main.

Files Patch % Lines
linkml_runtime/utils/schemaview.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
- Coverage   62.12%   61.99%   -0.13%     
==========================================
  Files          63       63              
  Lines        8477     8480       +3     
  Branches     2175     2176       +1     
==========================================
- Hits         5266     5257       -9     
- Misses       2601     2612      +11     
- Partials      610      611       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sierra-moxon sierra-moxon changed the title remove enum redundancy in get_slots_by_enum method remove slot name redundancy in get_slots_by_enum method Jan 8, 2024
Copy link
Member

@sujaypatil96 sujaypatil96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 removes redundant slots from being returned by get_slots_by_enum() method.

@sierra-moxon sierra-moxon merged commit 6763067 into main Jan 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants