Font fixes #12948
Merged
Font fixes #12948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… <HEAD> like we were with Lato, because apparently WAFs don't complain about that? Also yank Lato and Montserrat since they were kind of pointless. Fixes #8179 (hopefully). Signed-off-by: Flynn <[email protected]>
alpeb
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of loading Roboto from CSS (which, apparently, WAFs complain about), load it as a stylesheet in (which, apparently, WAFs don't complain about -- we were loading Lato that way before).
Also yank Lato and Montserrat since they were kind of pointless. Thanks to @travisbeckham for the suggestion here!
(I tested this with
bin/web dev, then loading the Viz dashboard in Safari so I could use the inspector to see what font was getting rendered for the text elements, to make sure that Roboto really does get loaded and used after this change.)Fixes #8179 (hopefully).
Signed-off-by: Flynn [email protected]