Statically link linkerd-await #418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Flynn <[email protected]>
olix0r
reviewed
May 16, 2024
| @@ -149,7 +149,7 @@ test *flags: | |||
|
|
|||
| # Build linkerd-await | |||
| build: | |||
| {{ _cargo }} build --frozen --target={{ _cargo_target }} \ | |||
There was a problem hiding this comment.
I don't think that this is enough to safely distribute a binary. As I search around, I find a bunch of information suggesting that there are problems statically linking against glibc. However, we have prior art for linking against musl:
This requires some CI surgery, but I can port one of these over.
Before doing that, though, I want to confirm that the original problem we're solving can't be more easily solved by rebuilding the binaries against a newer version of glibc.
There was a problem hiding this comment.
Ah. It looks like distributing binaries statically linked against GNU libc (LGPLv2.1) may have licensing implications, the extent of which I do not immediately understand.
|
Superseded by 9066973 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Flynn [email protected]