Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ability to toggle system site package inclusion in runtime #66

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ipmb
Copy link
Contributor

@ipmb ipmb commented Sep 23, 2018

This makes the zipapps work a little more like virtualenv. It uses the same default as virtualenv (no system site packages) which is not backwards compatible. To retain the current functionality, you can build with the --system-site-packages flag or add SHIV_SYSTEM_SITE_PACKAGES=True during runtime.

Original issue: #65
Includes #64 since this is related

@coveralls
Copy link

Pull Request Test Coverage Report for Build 166

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 16 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+1.8%) to 77.972%

Files with Coverage Reduction New Missed Lines %
.tox/py36/lib/python3.6/site-packages/shiv/cli.py 6 87.5%
.tox/py36/lib/python3.6/site-packages/shiv/bootstrap/init.py 10 63.77%
Totals Coverage Status
Change from base Build 159: 1.8%
Covered Lines: 223
Relevant Lines: 286

💛 - Coveralls

@ipmb
Copy link
Contributor Author

ipmb commented Sep 25, 2018

Just realized this doesn't account for removing paths added by .pth files. You'd probably need to do something like this as well https://github.com/pantsbuild/pex/blob/8f9c8ddfd4ac2cb0dc7ca566b392dc79f1fb324e/pex/pex.py#L262-L277

Base automatically changed from master to main February 11, 2021 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants