Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update typescript #2134

Merged
merged 1 commit into from
Dec 23, 2024
Merged

chore: update typescript #2134

merged 1 commit into from
Dec 23, 2024

Conversation

timofei-iatsenko
Copy link
Collaborator

Description

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Examples update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)

Copy link

vercel bot commented Dec 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview Dec 23, 2024 11:16am

Copy link

github-actions bot commented Dec 21, 2024

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 3.22 KB (0%)
./packages/detect-locale/dist/index.mjs 722 B (0%)
./packages/react/dist/index.mjs 1.65 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

@timofei-iatsenko
Copy link
Collaborator Author

Here is flay windows test is failing, not related to a changes in the PR.

I'm afraid we could not fix this flakiness easily, its related to the ESM incompatibility and Jest itself. To fix that we need to switch to Vitest and start transition to ESM modules

@andrii-bodnar andrii-bodnar merged commit ad0151c into main Dec 23, 2024
7 of 9 checks passed
@andrii-bodnar andrii-bodnar deleted the chore/update-typescript branch December 23, 2024 13:34
@andrii-bodnar
Copy link
Contributor

Here is flay windows test is failing, not related to a changes in the PR.

I'm afraid we could not fix this flakiness easily, its related to the ESM incompatibility and Jest itself. To fix that we need to switch to Vitest and start transition to ESM modules

I noticed this too (#2113), it started happening quite recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants