Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-708] change @Transactional readOnly for select query #710

Merged
merged 1 commit into from
May 20, 2024

Conversation

kihwankim
Copy link
Contributor

Motivation

  • in spring data jpa SimpleJpaRepository class declare @Transactional but in select query they put readOnly true

Modifications

  • spring data KotlinJdslJpqlExecutor class's @Transactional readOnly option changed(false -> true) for select query

Result

  • in select query readOnly option changed true -> false

Closes

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.01%. Comparing base (95304dd) to head (e8daa7e).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #710   +/-   ##
========================================
  Coverage    92.01%   92.01%           
========================================
  Files          335      335           
  Lines         3419     3419           
  Branches       203      203           
========================================
  Hits          3146     3146           
  Misses         213      213           
  Partials        60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shouwn
Copy link
Member

shouwn commented May 20, 2024

Thanks for your help!

@shouwn shouwn merged commit 64bead3 into line:develop May 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants