Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary code, maintain a consistent code style #650

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

waahhh
Copy link
Contributor

@waahhh waahhh commented Feb 21, 2024

Motivation

  • Unnecessary test code and inconsistent code style

Modifications

  • Remove unnecessary test stubbing code
  • Write with a consistent code style

Commit Convention Rule

Commit type Description
feat New Feature
fix Fix bug
docs Documentation only changed
ci Change CI configuration
refactor Not a bug fix or add feature, just refactoring code
test Add Test case or fix wrong test case
style Only change the code style(ex. white-space, formatting)
chore It refers to minor tasks such as library version upgrade, typo correction, etc.
  • If you want to add some more commit type please describe it on the Pull Request

Result

  • Maintain a consistent code style

Closes

  • #{issue number} (If this PR resolves an issue.)

Copy link
Member

@shouwn shouwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow thanks so much for styling codes!

@shouwn shouwn merged commit a1599c2 into line:develop Feb 21, 2024
4 checks passed
@waahhh waahhh deleted the fix/miscellaneous-code-style branch February 21, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants