Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Datetime function LOCAL DATE #632

Merged
merged 8 commits into from
Feb 8, 2024
Merged

Conversation

chicori3
Copy link
Contributor

@chicori3 chicori3 commented Feb 8, 2024

Motivation

  • Support Datetime function LOCAL DATE

Modifications

  • Create Jpql model and serializer for LOCAL DATE
  • Create JpqlLocalDate, Expressions, Serializer Test

Commit Convention Rule

Commit type Description
feat New Feature
fix Fix bug
docs Documentation only changed
ci Change CI configuration
refactor Not a bug fix or add feature, just refactoring code
test Add Test case or fix wrong test case
style Only change the code style(ex. white-space, formatting)
chore It refers to minor tasks such as library version upgrade, typo correction, etc.
  • If you want to add some more commit type please describe it on the Pull Request

Result

  • The Datetime function local date is created.

Closes

@CLAassistant
Copy link

CLAassistant commented Feb 8, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@shouwn shouwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the base branch from main to develop.

@shouwn
Copy link
Member

shouwn commented Feb 8, 2024

And please sign our Contributor License Agreement.
image

@chicori3 chicori3 changed the base branch from main to develop February 8, 2024 08:35
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4219a32) 91.97% compared to head (f99753f) 91.96%.
Report is 107 commits behind head on develop.

Files Patch % Lines
...er/jpql/serializer/impl/JpqlLocalDateSerializer.kt 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #632      +/-   ##
===========================================
- Coverage    91.97%   91.96%   -0.02%     
===========================================
  Files          297      299       +2     
  Lines         3215     3222       +7     
  Branches       195      195              
===========================================
+ Hits          2957     2963       +6     
- Misses         204      205       +1     
  Partials        54       54              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chicori3
Copy link
Contributor Author

chicori3 commented Feb 8, 2024

@shouwn i signed it :D

@shouwn
Copy link
Member

shouwn commented Feb 8, 2024

Thanks for your help!

@shouwn shouwn merged commit b3693a7 into line:develop Feb 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants