Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Arithmetic function LN #621

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Support Arithmetic function LN #621

merged 4 commits into from
Feb 5, 2024

Conversation

jbl428
Copy link
Contributor

@jbl428 jbl428 commented Jan 31, 2024

Motivation

  • Support an arithmetic function LN.

Modifications

  • Add jpql model and serializer for LN

Commit Convention Rule

Commit type Description
feat New Feature
fix Fix bug
docs Documentation only changed
ci Change CI configuration
refactor Not a bug fix or add feature, just refactoring code
test Add Test case or fix wrong test case
style Only change the code style(ex. white-space, formatting)
chore It refers to minor tasks such as library version upgrade, typo correction, etc.
  • If you want to add some more commit type please describe it on the Pull Request

Result

  • The arithmetic function ln is added.

Closes

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4bd0b22) 66.15% compared to head (3f049da) 66.22%.

Files Patch % Lines
...sl/render/jpql/serializer/impl/JpqlLnSerializer.kt 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #621      +/-   ##
===========================================
+ Coverage    66.15%   66.22%   +0.06%     
===========================================
  Files          455      457       +2     
  Lines         4698     4710      +12     
  Branches       277      277              
===========================================
+ Hits          3108     3119      +11     
- Misses        1533     1534       +1     
  Partials        57       57              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shouwn shouwn merged commit 0d9febd into line:develop Feb 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants