Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Arithmetic function FLOOR #617

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Conversation

sinkyoungdeok
Copy link
Contributor

@sinkyoungdeok sinkyoungdeok commented Jan 30, 2024

Motivation

  • Support Arithmetic function FLOOR.

Modifications

  • Create Jpql model and serializer for ROUND And Create JpqlRound, Expressions, Serializer Test

Commit Convention Rule

Commit type Description
feat New Feature
fix Fix bug
docs Documentation only changed
ci Change CI configuration
refactor Not a bug fix or add feature, just refactoring code
test Add Test case or fix wrong test case
style Only change the code style(ex. white-space, formatting)
chore It refers to minor tasks such as library version upgrade, typo correction, etc.
  • If you want to add some more commit type please describe it on the Pull Request

Result

  • The arithmetic function floor is created.

Closes

@CLAassistant
Copy link

CLAassistant commented Jan 30, 2024

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (aac989d) 91.98% compared to head (18a271b) 91.98%.

Files Patch % Lines
...render/jpql/serializer/impl/JpqlFloorSerializer.kt 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #617      +/-   ##
===========================================
- Coverage    91.98%   91.98%   -0.01%     
===========================================
  Files          305      307       +2     
  Lines         3269     3281      +12     
  Branches       195      195              
===========================================
+ Hits          3007     3018      +11     
- Misses         208      209       +1     
  Partials        54       54              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@shouwn shouwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help! Please sign our Contributor License Agreement.

image

@sinkyoungdeok
Copy link
Contributor Author

@shouwn Done with signing

@shouwn shouwn merged commit 720b54d into line:develop Jan 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants