Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add String functions(upper) #506

Merged
merged 8 commits into from
Oct 24, 2023
Merged

Conversation

waahhh
Copy link
Contributor

@waahhh waahhh commented Oct 23, 2023

Motivation

  • Support for String functions(upper)

Modifications

  • Add JpqlUpper, JpqlUpperSerializer, dsl for upper function with tests

Commit Convention Rule

Commit type Description
feat New Feature
fix Fix bug
docs Documentation only changed
ci Change CI configuration
refactor Not a bug fix or add feature, just refactoring code
test Add Test case or fix wrong test case
style Only change the code style(ex. white-space, formatting)
chore It refers to minor tasks such as library version upgrade, typo correction, etc.
  • If you want to add some more commit type please describe it on the Pull Request

Result

  • Please describe the result after this PR is merged.

Closes

  • #{issue number} (If this PR resolves an issue.)

Copy link
Member

@shouwn shouwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! I think it would be better to rename the parameter to value instead of string.

Since I'm releasing Kotlin JDSL 3.0.0 today, I'd like to include this PR in the 3.0.0 release, so I'll merge and fix it.

Thanks again for your contribution.

@shouwn shouwn merged commit e4434e4 into line:develop Oct 24, 2023
2 of 3 checks passed
@waahhh waahhh deleted the add-string-functions-upper branch November 2, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants