fix: change @transactional readOnly for select query

line · May 20, 2024 · e8daa7e · e8daa7e
1 parent 95304dd
commit e8daa7e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/...inecorp/kotlinjdsl/support/spring/data/jpa/javax/repository/KotlinJdslJpqlExecutorImpl.kt b/...inecorp/kotlinjdsl/support/spring/data/jpa/javax/repository/KotlinJdslJpqlExecutorImpl.kt
@@ -28,9 +28,9 @@ import javax.persistence.Query
 import javax.persistence.TypedQuery
 import kotlin.reflect.KClass
 
-@Transactional
 @NoRepositoryBean
 @SinceJdsl("3.0.0")
+@Transactional(readOnly = true)
 open class KotlinJdslJpqlExecutorImpl(
     private val entityManager: EntityManager,
     private val renderContext: RenderContext,
@@ -143,12 +143,14 @@ open class KotlinJdslJpqlExecutorImpl(
         return createSlice(query, query.returnType, pageable)
     }
 
+    @Transactional
     override fun <T : Any> update(
         init: Jpql.() -> JpqlQueryable<UpdateQuery<T>>,
     ): Int {
         return update(Jpql, init)
     }
 
+    @Transactional
     override fun <T : Any, DSL : JpqlDsl> update(
         dsl: JpqlDsl.Constructor<DSL>,
         init: DSL.() -> JpqlQueryable<UpdateQuery<T>>,
@@ -159,6 +161,7 @@ open class KotlinJdslJpqlExecutorImpl(
         return jpaQuery.executeUpdate()
     }
 
+    @Transactional
     override fun <T : Any, DSL : JpqlDsl> update(
         dsl: DSL,
         init: DSL.() -> JpqlQueryable<UpdateQuery<T>>,
@@ -169,12 +172,14 @@ open class KotlinJdslJpqlExecutorImpl(
         return jpaQuery.executeUpdate()
     }
 
+    @Transactional
     override fun <T : Any> delete(
         init: Jpql.() -> JpqlQueryable<DeleteQuery<T>>,
     ): Int {
         return delete(Jpql, init)
     }
 
+    @Transactional
     override fun <T : Any, DSL : JpqlDsl> delete(
         dsl: JpqlDsl.Constructor<DSL>,
         init: DSL.() -> JpqlQueryable<DeleteQuery<T>>,
@@ -185,6 +190,7 @@ open class KotlinJdslJpqlExecutorImpl(
         return jpaQuery.executeUpdate()
     }
 
+    @Transactional
     override fun <T : Any, DSL : JpqlDsl> delete(
         dsl: DSL,
         init: DSL.() -> JpqlQueryable<DeleteQuery<T>>,

diff --git a/.../com/linecorp/kotlinjdsl/support/spring/data/jpa/repository/KotlinJdslJpqlExecutorImpl.kt b/.../com/linecorp/kotlinjdsl/support/spring/data/jpa/repository/KotlinJdslJpqlExecutorImpl.kt
@@ -30,9 +30,9 @@ import org.springframework.data.support.PageableExecutionUtilsAdaptor
 import org.springframework.transaction.annotation.Transactional
 import kotlin.reflect.KClass
 
-@Transactional
 @NoRepositoryBean
 @SinceJdsl("3.0.0")
+@Transactional(readOnly = true)
 open class KotlinJdslJpqlExecutorImpl(
     private val entityManager: EntityManager,
     private val renderContext: RenderContext,
@@ -145,12 +145,14 @@ open class KotlinJdslJpqlExecutorImpl(
         return createSlice(query, query.returnType, pageable)
     }
 
+    @Transactional
     override fun <T : Any> update(
         init: Jpql.() -> JpqlQueryable<UpdateQuery<T>>,
     ): Int {
         return update(Jpql, init)
     }
 
+    @Transactional
     override fun <T : Any, DSL : JpqlDsl> update(
         dsl: JpqlDsl.Constructor<DSL>,
         init: DSL.() -> JpqlQueryable<UpdateQuery<T>>,
@@ -161,6 +163,7 @@ open class KotlinJdslJpqlExecutorImpl(
         return jpaQuery.executeUpdate()
     }
 
+    @Transactional
     override fun <T : Any, DSL : JpqlDsl> update(
         dsl: DSL,
         init: DSL.() -> JpqlQueryable<UpdateQuery<T>>,
@@ -171,12 +174,14 @@ open class KotlinJdslJpqlExecutorImpl(
         return jpaQuery.executeUpdate()
     }
 
+    @Transactional
     override fun <T : Any> delete(
         init: Jpql.() -> JpqlQueryable<DeleteQuery<T>>,
     ): Int {
         return delete(Jpql, init)
     }
 
+    @Transactional
     override fun <T : Any, DSL : JpqlDsl> delete(
         dsl: JpqlDsl.Constructor<DSL>,
         init: DSL.() -> JpqlQueryable<DeleteQuery<T>>,
@@ -187,6 +192,7 @@ open class KotlinJdslJpqlExecutorImpl(
         return jpaQuery.executeUpdate()
     }
 
+    @Transactional
     override fun <T : Any, DSL : JpqlDsl> delete(
         dsl: DSL,
         init: DSL.() -> JpqlQueryable<DeleteQuery<T>>,