Add BTEvaluateExpression

[Rubonnek]

Implements #12.

[Rubonnek]

This PR should be ready for review now.

I should say I'm not entirely sure how to concisely name set_expression_string-- set_expression sounds confusing since Expression exists but I don't mind changing it to the latter at all, or to something else.

Same goes for input_include_delta -- include_delta on its own sounds confusing to me within this context.

[limbonaut]

Excellent work! It'll make a great addition for 1.0 release. I'll check it out tomorrow, we'll see if I can break it.
Should change those copyrights for yours and also the filenames in the first line.

[limbonaut]

This PR should be ready for review now.

I should say I'm not entirely sure how to concisely name set_expression_string-- set_expression sounds confusing since Expression exists but I don't mind changing it to the latter at all, or to something else.

Same goes for input_include_delta -- include_delta on its own sounds confusing to me within this context.

The input_include_delta is a bit long, but it's fine. In the inspector, it'll be Input --- Include Delta. Doesn't look confusing to me. Plus we need that input_ for ADD_GROUP().
With the set_expression..., whichever you prefer. Both names look good to me.

[Rubonnek]

With the set_expression..., whichever you prefer. Both names look good to me.

I've left it as set_expression_string then.

Looks like the first argument in input_vars is skipped when delta is included

I've added a test for this -- should be fixed now.

Should change those copyrights for yours

Made the change but I'm conflicted about it -- BTEvaluateExpression is mostly a copy-paste of BTCallMethod.

I'm not a copyright law expert, but I wouldn't mind if you did the same as Godot by tracking contributors/donors in AUTHORS.md. We'll have to update the copyright notice to include that file and in the LimboAI editor list yourself and the contributors inside an About section, maybe under Misc, but I'm fine with however you want to handle it.

[Rubonnek]

I think this PR is ready for review again.

[limbonaut]

With the set_expression..., whichever you prefer. Both names look good to me.

I've left it as set_expression_string then.

Looks like the first argument in input_vars is skipped when delta is included

I've added a test for this -- should be fixed now.

Should change those copyrights for yours

Made the change but I'm conflicted about it -- BTEvaluateExpression is mostly a copy-paste of BTCallMethod.

I'm not a copyright law expert, but I wouldn't mind if you did the same as Godot by tracking contributors/donors in AUTHORS.md. We'll have to update the copyright notice to include that file and in the LimboAI editor list yourself and the contributors inside an About section, maybe under Misc, but I'm fine with however you want to handle it.

Not a copyright expert myself. Perhaps in that case, the copyright notice should be appended to mine:

Copyright YEAR mine
Copyright 2024 yours

Need to take a look at how Godot is doing it. Seems like a good idea with the AUTHORS.md.

[Rubonnek]

Not a copyright expert myself. Perhaps in that case, the copyright notice should be appended to mine:

Copyright YEAR mine
Copyright 2024 yours

Need to take a look at how Godot is doing it. Seems like a good idea with the AUTHORS.md.

This sounds much better to me. I've made that change.

I don't mind replacing my name on the copyright header with a reference to AUTHORS.md later.

[limbonaut]

Awesome, thanks!