Improve saving for built-in BTs attached to scenes #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limbonaut
force-pushed
the
fix-builtin-resource-save
branch
from
9f96332 to
591a1fe
Compare
Also fixes dirty state handling, however it's currently unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes built-in resources not being saved (on "Save" clicked in LimboAI editor or "Ctrl+Alt+S" pressed while editor is visible).
On
Ctrl+S, only external resources are currently saved.Ctrl+Sis bound to "Save Scene" Godot command, and I'm not sure if we should override its behavior by asking other scenes to be saved as well.There is also a problem with dirty state tracking and circular dependency loop, explained here: #240 (comment)