Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#160 Adds changelog, including Lightchain historical progress #169

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EnchanterIO
Copy link
Contributor

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests

@EnchanterIO EnchanterIO added the enhancement Something that it currently work but can be improved label May 30, 2019
@EnchanterIO EnchanterIO added this to the Rock&Roll milestone May 30, 2019
@EnchanterIO EnchanterIO requested a review from ggarri May 30, 2019 11:35
@EnchanterIO EnchanterIO self-assigned this May 30, 2019
Copy link
Contributor

@ggarri ggarri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the auto-generation of the CHANGELOG seems a great idea but I would rather remove the sections of Close Issues and Pull Requests as it is quite redundant, Bug and Improvements are enough to show the progress.

In addition to the autogenerated version we could tune it a bit to make it more readable as our issue titles might not be the best to understand the work done behind them.

@EnchanterIO
Copy link
Contributor Author

IMO the auto-generation of the CHANGELOG seems a great idea but I would rather remove the sections of Close Issues and Pull Requests as it is quite redundant, Bug and Improvements are enough to show the progress.

In addition to the autogenerated version we could tune it a bit to make it more readable as our issue titles might not be the best to understand the work done behind them.

I was thinking about that as well but then I came to the conclusion that changelog is for grouping progress per tags into timeline and shows what happened in the repository in general. So I find Close issues and pull requests useful.

Even more readable version of the changelog with titles and everything is the Release section where you have a nice title, the main goal of the release and additional info + uploaded binaries and everything.

That being said, we can also add titles to the changelog, it may improve it a bit.

Copy link
Contributor

@ggarri ggarri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to do a clean it up before merging as many of the PR and issues have not descriptive messages

Copy link
Contributor

@ggarri ggarri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for team agreement on CHANGELOG format. I did a quick research on other projects in our ecosystem I got the the following examples, all of them valid in my opinion:

None of them appears to be autogenerated and I would be more included for an autogenerated version but in order to produce a "good looking" version we would need to go back in our issues and PRs and rewrite them having a common convention.

@EnchanterIO EnchanterIO changed the title #160 Adds changelog, including Lightchain historical progress. #160 Adds changelog, including Lightchain historical progress May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something that it currently work but can be improved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants