-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Proto over HTTP #12
Comments
This was referenced Oct 1, 2018
frenchfrywpepper
added a commit
that referenced
this issue
Oct 2, 2018
Issue #12: Generate PHP Proto files
This Issue is currently on hold while we sort out what to do about our uint64 ids. |
frenchfrywpepper
added a commit
that referenced
this issue
Oct 3, 2018
The version of Thrift that was previously included in this library supported logs on the report level. The latest version supports logs at the span level.
frenchfrywpepper
added a commit
that referenced
this issue
Oct 3, 2018
The version of Thrift that was previously included in this library supported logs on the report level. The latest version supports logs at the span level.
frenchfrywpepper
added a commit
that referenced
this issue
Oct 3, 2018
The Proto transport should be considered beta. No performance testing has been done. Known issues: - GUIDs larger than PHP_MAX_INT will be truncted, this could lead to invalidly joined traces and/or traces that fail to join
frenchfrywpepper
added a commit
that referenced
this issue
Oct 3, 2018
Issue #12: Introduce generic objects to toThrift methods
frenchfrywpepper
added a commit
that referenced
this issue
Oct 3, 2018
The version of Thrift that was previously included in this library supported logs on the report level. The latest version supports logs at the span level.
frenchfrywpepper
added a commit
that referenced
this issue
Oct 3, 2018
Issue #12: Add support for span logs
frenchfrywpepper
added a commit
that referenced
this issue
Oct 3, 2018
frenchfrywpepper
added a commit
that referenced
this issue
Oct 3, 2018
The Proto transport should be considered beta. No performance testing has been done. Known issues: - GUIDs larger than PHP_MAX_INT will be truncted, this could lead to invalidly joined traces and/or traces that fail to join
frenchfrywpepper
added a commit
that referenced
this issue
Oct 11, 2018
Issue #12: Implement Proto support
Basic support has been added, but it has not been performance tested and there are known issues like #18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Motivation: Support a more compact encoding of report data without taking on the overhead of gRPC.
Future: Pave the way to removing Thrift as a reporting format in a future release. Thrift is more resource-intensive to encode and decode, and requires a large dependency on Thrift v0.9.2
The text was updated successfully, but these errors were encountered: