Skip to content

Commit

Permalink
Issue #12: Implement toProto and TransportHTTPProto
Browse files Browse the repository at this point in the history
The Proto transport should be considered beta. No performance
testing has been done.

Known issues:
- GUIDs larger than PHP_MAX_INT will be truncted, this could lead
to invalidly joined traces and/or traces that fail to join
  • Loading branch information
frenchfrywpepper committed Oct 3, 2018
1 parent 9a44762 commit c8c9964
Show file tree
Hide file tree
Showing 21 changed files with 1,952 additions and 292 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,4 @@ thrift:
proto:
protoc --proto_path "$(PWD)/../googleapis:$(PWD)/../lightstep-tracer-common/" \
--php_out="$(PWD)/lib/generated" \
collector.proto
collector.proto google/api/annotations.proto google/api/http.proto
3 changes: 2 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@
"description": "LightStep instrumentation API",
"license": "MIT",
"require": {
"ruafozy/mersenne-twister": "^1.3"
"ruafozy/mersenne-twister": "^1.3",
"google/protobuf": ">=3.6.1"
},
"require-dev": {
"phpdocumentor/phpdocumentor": "^2.8.5",
Expand Down
Loading

0 comments on commit c8c9964

Please sign in to comment.