-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full mock coverage #13
Conversation
make remaining hdk_functions mockablecurrent plan:
|
@WFinck97 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all my change requests are expressed as mergeable suggestions.
You can use the bulk 'add suggestion to batch' feature to merge them all at once.
So close! Excellent
/// A triple of an Entry along with the HeaderHash | ||
/// of that committed entry and the EntryHash of the entry | ||
pub type EntryAndHash<T> = (T, HeaderHash, EntryHash); | ||
|
||
/// The same as an EntryAndHash but inside an Option, | ||
/// so it can be Some(...) or None | ||
pub type OptionEntryAndHash<T> = Option<EntryAndHash<T>>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would prefer these to be in a spot like 'types' or something, but not going to ask that to be done right now.
Co-authored-by: Connor Turland <[email protected]>
an hdk_crud refactor to be able to mock all the exposed functions for unit testing on the consumer side.
closes #12
inner_
crud functions into genericactions
Follow ups (split into separate issue and PR)
new()
ordefault()
that constructs a Fetcher #11