Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlc: bump version #847

Merged
merged 4 commits into from
Mar 21, 2024
Merged

sqlc: bump version #847

merged 4 commits into from
Mar 21, 2024

Conversation

guggero
Copy link
Member

@guggero guggero commented Mar 20, 2024

Fixes #831.

@guggero guggero requested review from ffranr and jharveyb March 20, 2024 12:52
@guggero
Copy link
Member Author

guggero commented Mar 20, 2024

This PR bumps the etcd dependencies to a newer version, which causes the grpc-gateway/v2 library to be bumped as well, which results in a diff in the *.swagger.json files. I hope that doesn't affect the API generator, otherwise we might need to roll back that change (or update the API generator). We'll know once we merge this PR to main and the nightly API generator job runs.
FYI @jamaljsr.

@ffranr
Copy link
Contributor

ffranr commented Mar 20, 2024

We'll know once we merge this PR to main and the nightly API generator job runs.

I wasn't aware of that job. Where is it defined please @guggero ?

@guggero
Copy link
Member Author

guggero commented Mar 20, 2024

The code is here: https://github.com/lightninglabs/lightning-api-ng
The actual job is in a private repo, I'll send you the link offline.

@jamaljsr
Copy link
Member

Thanks for the heads up @guggero.

I just tested locally and thankfully it doesn't break the build. However, it's no longer detecting the REST Type and Placement for the fields that are in the body of the request messages. It's showing unknown for these fields.

image

I'll work on a PR to resolve the issue. It shouldn't be too difficult.

Copy link
Contributor

@jharveyb jharveyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up! LGTM

guggero added 3 commits March 21, 2024 08:39
With this commit we update to the latest version of sqlc that fixes a
bug we previously needed to patch manually.
@guggero guggero enabled auto-merge March 21, 2024 07:41
@guggero guggero added this pull request to the merge queue Mar 21, 2024
Merged via the queue into main with commit 7863415 Mar 21, 2024
14 checks passed
@guggero guggero deleted the sqlc-maintenance branch March 21, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tapdb: remove LEFT JOIN adjustment script
4 participants