Makefile optimizations #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally, `git describe` will fail if it can't find a tag to describe the commit. The `--always` option ensures it doesn't fail by falling back to just outputting the full hash of the commit.
The value of `tags` is already appended to the existing value of `DEV_TAGS` in `testing_flags.mk`, line 57. This results duplication of the value passed with the `tags` variable.
GeorgeTsagk
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two improvements:
tagsvariable results in the tags being added twice. This PR removes that redundancy.git describeto fail if it can't find a tag to describe the commit.