Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tapgarden: tapscript tree support for minting anchor outputs #768

Merged
merged 19 commits into from
Feb 27, 2024
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address: update handling of tapscript preimages
jharveyb committed Feb 26, 2024
commit f6dd14a08492ea5a083b46bba7d9d7faff86fd6a
4 changes: 2 additions & 2 deletions address/address.go
Original file line number Diff line number Diff line change
@@ -196,9 +196,9 @@ func New(version Version, genesis asset.Genesis, groupKey *btcec.PublicKey,
// We can only use a tapscript sibling that is not a Taproot Asset
// commitment.
if tapscriptSibling != nil {
if err := tapscriptSibling.VerifyNoCommitment(); err != nil {
if _, err := tapscriptSibling.TapHash(); err != nil {
return nil, errors.New("address: tapscript sibling " +
"is a Taproot Asset commitment")
"is invalid")
}
}

11 changes: 9 additions & 2 deletions address/records.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package address

import (
"bytes"
"net/url"

"github.com/btcsuite/btcd/btcec/v2"
@@ -86,8 +87,14 @@ func newAddressTapscriptSiblingRecord(
tapscriptSibling **commitment.TapscriptPreimage) tlv.Record {

sizeFunc := func() uint64 {
// 1 byte for the type, and then the pre-image itself.
return 1 + uint64(len((*tapscriptSibling).SiblingPreimage))
var buf bytes.Buffer
err := commitment.TapscriptPreimageEncoder(
&buf, tapscriptSibling, &[8]byte{},
)
if err != nil {
panic(err)
}
return uint64(len(buf.Bytes()))
}
return tlv.MakeDynamicRecord(
addrTapscriptSiblingType, tapscriptSibling, sizeFunc,