Universe events stats handle universe identity proof type #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffranr
force-pushed
the
uni-events-proof-type
branch
from
646b3d1 to
e90f314
Compare
Roasbeef
reviewed
Oct 11, 2023
guggero
reviewed
Oct 11, 2023
ffranr
force-pushed
the
uni-namespace-proof-type
branch
from
6bb6a33 to
b2d27d6
Compare
ffranr
force-pushed
the
uni-events-proof-type
branch
from
e90f314 to
fbab2ec
Compare
|
@Roasbeef stats are still aggregated as before. This PR adds proof type resolution to how we store stats, but stats are still queried and aggregated as before. |
The universe_stats view represents per asset/asset group aggregated stats. However, the universe namespace field is now specific to a proof type. This commit removes the namespace field from the stats group by.
ffranr
force-pushed
the
uni-events-proof-type
branch
from
fbab2ec to
91186e6
Compare
guggero
reviewed
Oct 11, 2023
There was a problem hiding this comment.
Did a bunch of manual testing and found a bunch of small things that should be fixed.
Summarized them in this commit (feel free to just take over/split into fixup commits): https://github.com/lightninglabs/taproot-assets/tree/561-fixups
With those fixes applied, I think this is ready to go.
Roasbeef
reviewed
Oct 11, 2023
ffranr
force-pushed
the
uni-events-proof-type
branch
from
111d885 to
dec1676
Compare
guggero
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #540 . Do not merge this PR before merging #540 I've converted this PR to draft until all parent PRs have been merged.
This PR adds universe identity proof type support to universe events stats database SQL statements.