PoC: Use tweaked NUMS key for non-spendable Taproot script leaves #1289
+48
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With this change. tapd nodes v0.5 and older will fail to validate new group key V1 assets. |
Pull Request Test Coverage Report for Build 12733974902Details
💛 - Coveralls |
ffranr
force-pushed
the
nums-non-spend-leaves
branch
from
af75235 to
f6a7f79
Compare
ffranr
changed the title
This Proof-of-Concept demonstrates the NUMS-tweak formulation for hardware wallet testing. The NewNonSpendableScriptLeaf function now generates non-spendable Taproot leaves using a deterministic NUMS (Nothing-Up-My-Sleeve) key, tweaked with arbitrary data. This replaces the previous raw OP_RETURN approach with a `pk(data)` Miniscript script (`<pubkey> OP_CHECKSIG`), improving compatibility with current hardware wallets.
ffranr
force-pushed
the
nums-non-spend-leaves
branch
from
f6a7f79 to
d09b5bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This serves as a PoC which we should be able to use to test hardware wallets. This PR does not include all necessary doc updates.
This PR updates the
NewNonSpendableScriptLeaffunction to use a deterministic tweaked NUMS (Nothing-Up-My-Sleeve) key for generating non-spendable Taproot leaves. The previousOP_RETURN-based approach is replaced with apk(data)Miniscript script (<pubkey> OP_CHECKSIG), ensuring broader compatibility with modern hardware wallets.Notes for Reviewers