New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github: update upload-artifact action to v4 #1288

Open

dstadulis wants to merge 1 commit into lightninglabs:main from dstadulis:bumpUploadArtifactVersion

Collaborator

dstadulis commented Jan 10, 2025 •

edited

Loading

PR to update github actions

context: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
migration notes: https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md

TY to @ellemouton for researching the necessary update steps

TODO

Consider what logging artifact exists to prevent name-spacing collisions


          .github: update upload-artifact action to v4

fdcce76

dstadulis added the CI label

dstadulis self-assigned this

coveralls commented Jan 10, 2025

Pull Request Test Coverage Report for Build 12712820961

Details

0 of 0 changed or added relevant lines in 0 files are covered.
11 unchanged lines in 4 files lost coverage.
Overall coverage increased (+0.03%) to 40.966%

Files with Coverage Reduction	New Missed Lines	%
tappsbt/create.go	2	53.22%
tapgarden/planter.go	2	74.12%
asset/asset.go	2	80.81%
tapchannel/aux_leaf_signer.go	5	43.08%

Totals
Change from base Build 12650018423:	0.03%
Covered Lines:	26419
Relevant Lines:	64490

💛 - Coveralls

ellemouton reviewed

View reviewed changes

Member

ellemouton left a comment

there are other uses of upload-artifact@v3 in this file that also need to be bumped to v4

Member

ellemouton commented Jan 10, 2025 •

edited

Loading

also, who is the author of this commit? is the author meant to be this @nehhen user?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI