Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asset: add more test cases for ExternalKey.PubKey #1286

Conversation

starius
Copy link

@starius starius commented Jan 9, 2025

Added more derivation paths and corresponding public keys, check in the test that the values returned by the method match to expected values. Also added tpub (testnet xpub).

To run "chantools derivekey" with xpubs, use PR lightninglabs/chantools#179

Added more derivation paths and corresponding public keys, check in the test
that the values returned by the method match to expected values. Also added
tpub (testnet xpub).

To run "chantools derivekey" with xpubs, use PR
lightninglabs/chantools#179
@starius starius marked this pull request as ready for review January 9, 2025 19:09
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12696712738

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 28 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.009%) to 40.825%

Files with Coverage Reduction New Missed Lines %
tappsbt/create.go 2 53.22%
asset/asset.go 2 77.38%
fn/option.go 3 43.3%
tapchannel/aux_leaf_signer.go 3 43.43%
commitment/tap.go 3 83.64%
asset/mock.go 3 92.71%
tapchannel/aux_invoice_manager.go 6 83.25%
tapdb/multiverse.go 6 68.21%
Totals Coverage Status
Change from base Build 12689774591: -0.009%
Covered Lines: 26535
Relevant Lines: 64997

💛 - Coveralls

@ffranr
Copy link
Contributor

ffranr commented Jan 10, 2025

Thank you very much for this! I've cherry picked your commit into #1284 so that we can avoid the merge commit. The commit still has you as the author and so on.

@ffranr ffranr closed this Jan 10, 2025
@dstadulis dstadulis added this to the v0.6 milestone Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants