Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts: update Roasbeef's key ID in verify-install.sh #1249

Merged
merged 1 commit into from
Dec 12, 2024
Merged

scripts: update Roasbeef's key ID in verify-install.sh #1249

merged 1 commit into from
Dec 12, 2024

Conversation

guggero
Copy link
Member

@guggero guggero commented Dec 12, 2024 •
edited
Loading

This was overlooked in #1229.
We're updating to the parent key ID
A5B61896952D9FDA83BC054CDC42612E89237182.

$ cat scripts/keys/roasbeef.asc| gpg --with-colons --import-options show-only --import

pub:-:255:22:DC42612E89237182:1729552568:::-:::scESCA:::::ed25519:::0:
fpr:::::::::A5B61896952D9FDA83BC054CDC42612E89237182: 
uid:-::::1729552794::8D805FB762825ECBDA00EB0AF5FEDF76DE288546::Olaoluwa Osuntokun <[email protected]>::::::::::0:
sub:-:255:18:19E88A946BEF6D65:1729552568:1761088568:::::e:::::cv25519:: 
fpr:::::::::70206BBE2C0A81EC381A212C19E88A946BEF6D65: 
sub:-:255:22:966072F65DF1D016:1729552672:1761088672:::::a:::::ed25519::
fpr:::::::::98E3632DC026406855001E22966072F65DF1D016: 
sub:-:255:22:90525F7DEEE0AD86:1729552758:1761088758:::::s:::::ed25519:: 
fpr:::::::::296212681AADF05656A2CDEE90525F7DEEE0AD86:

@guggero
scripts: update Roasbeef's key ID in verify-install.sh
3e4a647 
This was overlooked in #1229.
We're updating to the parent key ID
A5B61896952D9FDA83BC054CDC42612E89237182.

cat scripts/keys/roasbeef.asc| gpg --with-colons --import-options show-only --import                                                                   ─╯
pub:-:255:22:DC42612E89237182:1729552568:::-:::scESCA:::::ed25519:::0:
fpr:::::::::A5B61896952D9FDA83BC054CDC42612E89237182:
uid:-::::1729552794::8D805FB762825ECBDA00EB0AF5FEDF76DE288546::Olaoluwa Osuntokun <[email protected]>::::::::::0:
sub:-:255:18:19E88A946BEF6D65:1729552568:1761088568:::::e:::::cv25519::
fpr:::::::::70206BBE2C0A81EC381A212C19E88A946BEF6D65:
sub:-:255:22:966072F65DF1D016:1729552672:1761088672:::::a:::::ed25519::
fpr:::::::::98E3632DC026406855001E22966072F65DF1D016:
sub:-:255:22:90525F7DEEE0AD86:1729552758:1761088758:::::s:::::ed25519::
fpr:::::::::296212681AADF05656A2CDEE90525F7DEEE0AD86:
@guggero guggero requested a review from Roasbeef December 12, 2024 08:57
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12292987215

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 18 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.008%) to 40.708%
Files with Coverage Reduction New Missed Lines %
tappsbt/create.go 2 53.22%
tapgarden/planter.go 2 74.12%
tapdb/addrs.go 2 75.09%
tapchannel/aux_leaf_signer.go 3 43.43%
tapgarden/caretaker.go 4 68.87%
commitment/tap.go 5 83.64%
Totals Coverage Status
Change from base Build 12278230810: 0.008%
Covered Lines: 25819
Relevant Lines: 63425
💛 - Coveralls

Roasbeef
Roasbeef approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏵️

@Roasbeef Roasbeef merged commit 35d8f1c into main Dec 12, 2024
18 checks passed
@guggero guggero deleted the update-roasbeef-key branch December 12, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roasbeef Roasbeef Roasbeef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Taproot-Assets Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guggero @coveralls @Roasbeef