Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version: bump to version v0.5.0-alpha.rc1 #1221

Merged
merged 1 commit into from
Nov 27, 2024
Merged

version: bump to version v0.5.0-alpha.rc1 #1221

merged 1 commit into from
Nov 27, 2024

Conversation

guggero
Copy link
Member

@guggero guggero commented Nov 27, 2024

Prepare for tagging a first RC of v0.5.0-alpha.

To be merged AFTER #1209.

Requesting review from the whole team to share the joy of achieving this milestone.

@coveralls
Copy link

coveralls commented Nov 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12057203852

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 13 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.01%) to 40.883%
Files with Coverage Reduction New Missed Lines %
tappsbt/create.go 2 53.22%
asset/asset.go 2 81.3%
tapgarden/caretaker.go 4 68.5%
tapchannel/aux_leaf_signer.go 5 43.08%
Totals Coverage Status
Change from base Build 12057197020: 0.01%
Covered Lines: 25789
Relevant Lines: 63080
💛 - Coveralls

@dstadulis
Copy link
Collaborator

dstadulis commented Nov 27, 2024 •
edited
Loading

+1 to merge #1221, after CI passes for #1209 and is approved by reviewers

https://github.com/lightninglabs/taproot-assets/actions/runs/12054615315/job/33613067015?pr=1221#step:9:1575

rpc error: code = DeadlineExceeded desc = context deadline exceeded
        	Test:       	TestLightningTerminal/test_custom_channels

Is this instance of Context deadline being exceeded possibly a flake?

@guggero
Copy link
Member Author

guggero commented Nov 27, 2024 •
edited
Loading

Is this instance of Context deadline being exceeded possibly a flake?

No, it's because #1209 hasn't been merged yet.

@dstadulis dstadulis added this to the v0.5 (v0.4.2 rename) milestone Nov 27, 2024
@jharveyb
Copy link
Contributor

Confirmed that this is using the same field as the previous RC cycle.

gijswijs
gijswijs approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@gijswijs gijswijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG! 🔥

dstadulis
dstadulis approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@dstadulis dstadulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Merge sign! LFG! 🏴

@guggero guggero merged commit 4205556 into main Nov 27, 2024
18 checks passed
@guggero guggero deleted the bump-version-0-5-0 branch November 27, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgeTsagk GeorgeTsagk GeorgeTsagk approved these changes

@dstadulis dstadulis dstadulis approved these changes

@gijswijs gijswijs gijswijs approved these changes

@Roasbeef Roasbeef Awaiting requested review from Roasbeef

@ffranr ffranr Awaiting requested review from ffranr

@jharveyb jharveyb Awaiting requested review from jharveyb

Assignees

@guggero guggero

Labels
None yet
Projects
Taproot-Assets Project Board
Status: ✅ Done
Milestone
v0.5
Development

Successfully merging this pull request may close these issues.
6 participants
@guggero @coveralls @dstadulis @jharveyb @gijswijs @GeorgeTsagk