tapcfg: add flag to disable default federation server #1190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11842131999Details
💛 - Coveralls |
This commit adds a new universe.no-default-federation boolean flag that allows the user to disable adding the default federation server.
guggero
force-pushed
the
no-default-universe
branch
from
eb54840 to
01061fd
Compare
jharveyb
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Tested manually on mainnet with CLI flag --universe.no-default-federation, worked as expected.
As is it won't delete the default universe(s) if it's already been added, but if you do delete the default, and reboot with the flag set, the default will not be added to the config.
Thanks for taking care of this! 🎉
gijswijs
pushed a commit
that referenced
this pull request
Nov 20, 2024
tapcfg: add flag to disable default federation server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1024.
This commit adds a new universe.no-default-federation boolean flag that allows the user to disable adding the default federation server.