Refactor RFQ BuyOrder struct #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor BuyOrder by replacing the fields "asset ID" and "asset group key" with a single "asset specifier" field for simplicity and consistency.
This commit repurposes the `MinAssetAmount` field in `BuyOrder` to `AssetMaxAmt`, defining the upper limit on the inbound asset amount from the RFQ initiator's perspective. This change applies when the requestor sets up an invoice to receive payment in tap asset (sending a "buy" RFQ request). The `AssetMaxAmt` field will be populated in a `BuyRequest` to ensure that the counterparty can accommodate this requirement.
This commit removes an unused field.
ffranr
force-pushed
the
buyorder-refactor
branch
from
6e10413 to
853ff2a
Compare
Pull Request Test Coverage Report for Build 11709454558Details
💛 - Coveralls |
Currently, the `BuyOrder.Peer` field must be specified, but in the future, the negotiator should be able to select the optimal peer automatically. This commit updates the interface to support this future functionality by making `BuyOrder.Peer` an Option type. Note that this field was already a pointer.
ffranr
force-pushed
the
buyorder-refactor
branch
from
853ff2a to
7f95ca1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fn.Option.