Include base input fee in fee, in calculate_our_funding_satoshis() #3558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: #3407 also include this change, I will take care of merge if needed regardless of which PR is merged first. |
optout21
force-pushed
the
funding-fee-estimation
branch
from
8240846 to
4a4ae72
Compare
optout21
force-pushed
the
funding-fee-estimation
branch
from
4a4ae72 to
27784d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on checks for splicing (#3407), it was found that the still-unused
calculate_our_funding_satoshis()method does not take into account the base weight of the inputs in the fee estimation.This change:
calculate_our_funding_satoshis()(1st commit)calculate_our_funding_satoshis()into two,estimate_funding_transaction_fee(), and the output calculation. This is to allow using funding tx fee estimation, needed also by splicing (see [Splicing] Partial, handle splice_init & splice_ack messages #3407).