utils cleanups
#3552
Merged
utils cleanups
#3552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`test_utils` is ancient and didn't import common types like `ChannelMonitor` for some reason. Here we do that, cleaning up some code.
PR lightningdevkit#3323 introduced some extra variables to avoid `rustfmt` making a total mess of our code, but introduced a few that don't make `rustfmt` do dumb things, which we remove here.
TheBlueMatt
force-pushed
the
2025-01-3323-followups
branch
from
9d6700f to
bc7631f
Compare
valentinewallace
approved these changes
Jan 21, 2025
valentinewallace
merged commit 3d2b4de
into
lightningdevkit:main
24 of 25 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few small cleanups post-#3323.