Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testgen: added EIP 7702 transaction receipt test and SignAuth #38

Merged
merged 8 commits into from
Jan 5, 2025

Conversation

PelleKrab
Copy link
Contributor

@PelleKrab PelleKrab commented Sep 28, 2024

Changes:

  • Added eth_getTransactionByHash, eth_getTransactionReceipt, and eth_getTransactionRawTransaction test.
  • Added SignAuth() to simplify SetCode authorization signing.

testgen/generators.go Outdated Show resolved Hide resolved
@fjl
Copy link
Collaborator

fjl commented Dec 17, 2024

I've opened #39 for Prague tests. Would be nice to rebase this once that's in. Some 7702 things are already covered by #39, but transaction sending isn't.

@PelleKrab PelleKrab changed the title Added EIP 7702 tests and GetPrivateKey() Added EIP 7702 Transaction tests and GetPrivateKey() Dec 19, 2024
@PelleKrab
Copy link
Contributor Author

Everything is working except send-authorization-list-tx is getting a "failed to fill eth_sendRawTransaction/send-authorization-list-tx: transaction type not supported: received type 4" error. Not sure if this is an rpctestgen config issue, but I am looking into it, and ./mkchain.sh seems to be working.

@PelleKrab PelleKrab changed the title Added EIP 7702 Transaction tests and GetPrivateKey() Added EIP 7702 Transaction tests and SignAuth() Jan 4, 2025
@PelleKrab
Copy link
Contributor Author

Everything is working except send-authorization-list-tx is getting a "failed to fill eth_sendRawTransaction/send-authorization-list-tx: transaction type not supported: received type 4" error. Not sure if this is an rpctestgen config issue, but I am looking into it, and ./mkchain.sh seems to be working.

The issue is go-ethereum master doesn't include 7702 into the legacy subpool. I implemented this on my local repo and the test filled. Should I make a PR on go-ethereum or is this intentional? @fjl

@fjl
Copy link
Collaborator

fjl commented Jan 4, 2025

It's intentional. We are still working on proper 7702 support in txpool. It's not as simple as just enabling it.

@PelleKrab
Copy link
Contributor Author

So 7702 transaction sending in rpctestgen is blocked until proper support is figured out, correct?

@fjl
Copy link
Collaborator

fjl commented Jan 5, 2025

Yeah, for now.

@fjl
Copy link
Collaborator

fjl commented Jan 5, 2025

I have removed the tx send test for now. We can add this later when Geth supports it.

@fjl fjl changed the title Added EIP 7702 Transaction tests and SignAuth() testgen: added EIP 7702 transaction receipt test and SignAuth Jan 5, 2025
@fjl fjl merged commit 3d29578 into lightclient:main Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants