Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LONG Token on zkSync Era network (Update ERA.json) #123

Merged
merged 6 commits into from
Dec 27, 2024

Conversation

ZkSwapFinance
Copy link
Contributor

update token Long on zkSync Era network
update logo link
tokens/ERA.json Outdated
"chainId":324,
"symbol":"LONG",
"decimals":18,
"name":"LONG",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the debank information, the name is Long.

Original return:

{
   "id":"0x5165ec33b491d7b67260b3143f96bb4ac4736398",
   "chain":"era",
   "name":"Long",
   "symbol":"LONG",
   "display_symbol":null,
   "optimized_symbol":"LONG",
   "decimals":18,
   "logo_url":"https://static.debank.com/image/era_token/logo_url/0x5165ec33b491d7b67260b3143f96bb4ac4736398/3e61868b9b13b95a7e6809647050f474.png",
   "protocol_id":"",
   "price":1.4259773351751368e-06,
   "price_24h_change":0.05325374617979149,
   "credit_score":29132.19030253106,
   "is_verified":true,
   "is_scam":false,
   "is_suspicious":false,
   "is_core":true,
   "is_wallet":true,
   "time_at":1711191402.0,
   "low_credit_score":false
}

]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the format of this bracket

Copy link
Contributor

@myz1237 myz1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented

@ZkSwapFinance
Copy link
Contributor Author

commented

Is everything okay? Do we need to create a new PR to change the 'name' field?

@myz1237
Copy link
Contributor

myz1237 commented Dec 27, 2024

commented

Is everything okay? Do we need to create a new PR to change the 'name' field?

Could you change it in your pr and push commits here? Change the name and bracket here:
image

Thanks in advance

@ZkSwapFinance
Copy link
Contributor Author

commented

Is everything okay? Do we need to create a new PR to change the 'name' field?

Could you change it in your pr and push commits here? Change the name and bracket here: image

Thanks in advance

I pushed a new commit with the name field changed. Could you verify it again?

@myz1237 myz1237 merged commit 2e74b7d into lifinance:main Dec 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants