Fix scroll verification

[0xDEnYO]

Which Jira task belongs to this PR?

Why did I implement it this way?

Checklist before requesting a review

• I have performed a self-review of my code
• This pull request is as small as possible and only tackles one problem
• I have added tests that cover the functionality / test the bug
• For new facets: I have checked all points from this list: https://www.notion.so/lifi/New-Facet-Contract-Checklist-157f0ff14ac78095a2b8f999d655622e
• I have updated any required documentation

Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)

• I have checked that any arbitrary calls to external contracts are validated and or restricted
• I have checked that any privileged calls (i.e. storage modifications) are validated and or restricted
• I have ensured that any new contracts have had AT A MINIMUM 1 preliminary audit conducted on by <company/auditor>

[coderabbitai]

Walkthrough

This pull request involves two files: deployments/_deployments_log_file.json and foundry.toml. The JSON file receives minor structural corrections with additional closing braces, ensuring proper JSON formatting. In the foundry.toml, the Scroll network's Etherscan API endpoint is updated from the original Etherscan URL to a new ScrollScan API URL, while maintaining the same chain ID and API key configuration.

Changes

File	Change Summary
deployments/_deployments_log_file.json	Added closing braces to correct JSON structure in the "CONSTRUCTOR_ARGS" section
foundry.toml	Updated Scroll network's Etherscan API URL from https://api.etherscan.io/v2/api?chainid=534352 to https://api.scrollscan.com/api

Possibly related PRs

• updated foundry.toml with etherscanV2 links #926: Changes in deployment configuration that could indirectly impact how deployment logs and configurations are managed

Suggested reviewers

• ezynda3

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 89e6c70 and 7010f68.

📒 Files selected for processing (2)

• deployments/_deployments_log_file.json (2 hunks)
• foundry.toml (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• deployments/_deployments_log_file.json

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: enforce-min-test-coverage
• GitHub Check: run-unit-tests
• GitHub Check: enforce-min-test-coverage

🔇 Additional comments (1)

foundry.toml (1)

104-104: LGTM! Verify the ScrollScan API endpoint.

The change from Etherscan to ScrollScan's dedicated API endpoint is correct for Scroll network verification. This aligns with how other L2 networks are configured in the file.

Let's verify the API endpoint is accessible and returns the expected response:

✅ Verification successful

ScrollScan API endpoint configuration is correct and operational ✅

The API endpoint is properly configured and follows the same pattern as other L2 networks with dedicated block explorers (e.g., BobaScan, Snowtrace). Our test confirms the endpoint is accessible and properly enforces API key authentication.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that the ScrollScan API endpoint is accessible and returns a valid response

# Test the API endpoint with a basic request
curl -s "https://api.scrollscan.com/api?module=proxy&action=eth_blockNumber" | jq .

# Note: This will help confirm the API is accessible and responding with valid JSON

Length of output: 166

---

Script:

#!/bin/bash
# Search for any ScrollScan API related documentation or usage
rg -i "scrollscan.com/api" --type md
rg -i "scrollscan" --type md

# Check if there are any other similar API configurations in foundry.toml
cat foundry.toml

Length of output: 6627

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[lifi-action-bot]

Test Coverage Report

Line Coverage: 78.66% (2238 / 2845 lines)
Function Coverage: 84.71% ( 388 / 458 functions)
Branch Coverage: 39.60% ( 221 / 558 branches)
Test coverage (78.66%) is above min threshold (76%). Check passed.

[lifi-action-bot]

Test Coverage Report

Line Coverage: 78.66% (2238 / 2845 lines)
Function Coverage: 84.71% ( 388 / 458 functions)
Branch Coverage: 39.60% ( 221 / 558 branches)
Test coverage (78.66%) is above min threshold (76%). Check passed.